這幾句英文有沒有錯

I am not saying they are wrong, but I think u can do better.

Say for the first sentence, I am not sure what you want to say.

Second sentence, I think u have a spelling mistake?

Third sentence, you might want to put it this way:
Terry is very tall; in contrast, XXX is much shorter despite the fact that she is elder.

Sentence for - take into account

I would take into account your ideas when I present our proposal to the client.
OR
I would have been working over 80 hours this week if I take into account all those extra time I spent on cleaning up his mess!

Sentence for - hold a positive attitude towards sb/sth

I always hold a positive attitude towards everything I do
OR
One essential element for happiness is to hold a positive attitude towards obstacles encountered in life!

to take XXX into account = to consider XXX

You need to take both costs and benefits into account when making a decision. => You need to consider both costs and benefits when making a decision.

to hold a positive attitude towards = to feel positive about

You should hold a positive attitude towards your job if you want to succeed. => You should feel positive about your job if you want to succeed.

====

They had to take money into account when they wanted to go out.

Your original statement has an extra "the" that causes the statement to become grammatically incorrect. Now, it means that they need to consider money -- the cost -- when they wanted to go out. It does *not* mean that they have to take/get money before they go out.

His teacher cannot put up with his attitude.
His teacher cannot put up with his attitude towards studying.

"Attitude of spirit" is incorrect usage.

In contrast with = Comparing against something that is opposite/different

Firemen work 24-hour shifts. Policemen work 8-hour shifts.
=> In contrast with firemen, policemen work 8-hour shifts.

They had to take the money into account when they wanted to go out.
I not sure what you mean here but I guess this is what you are trying to deliver: Whenever they leave the office/shop they have to deposit the money/take (it means income of the day if it is a shop) into the bank account.

His teacher can't put up with his attitude of spitit.
I think you mean: His teacher is tired of his bad attitude.

In contrast with brothers and sisters,terry is taller.
This can be written: Compare to his brothers and sisters (or you can use 'siblings' to replace 'brothers and sisters'), Terry is taller.

還有take into account and hold a positive attitude towards sb/sth點作句..唔該
take into account: When you are doing a survey, you have to take into account all the factors affecting people's answer.
hold a positive attitude towards sb/sth: When you start working you ought to hold a positive attitude towards the job, otherwise you may loose it easily.